-----Original Message----- From: Bryce Evans [mailto:bryceevans@xxxxxxxxx] Subject: PROBLEM: sas_address sysfs attribute empty on E208i-p SR Gen10 The sas_address device attribute in sas_device sysfs in is 0x0, and missing (empty or null?) in scsi_disk sysfs on LTS kernel 5.10.x, and Stable 5.13.1 Specifically /sys/class/scsi_disk/X:X/device/sas_address and /sys/class/sas_device/end_device-X:X/sas_address are null and 0x0 respectively Using this device in hba mode (pass through) - Serial Attached SCSI controller: Adaptec Smart Storage PQI 12G SAS/PCIe 3 (rev 01) Subsystem: Hewlett-Packard Company Smart Array E208i-p SR Gen10 This appears to have regressed some time after 4.19 (expected results from 4.19 below) It seems that systemd udev depends on this attribute from sysfs to populate /dev/disk/by-path, and when it is unavailable the sas_address shows as 0x0, which breaks population of this directory, potentially breaking userspace tools that rely on this ... Don: This patch redacted exporting SAS addresses for non-SAS devices ce1437935064 ("scsi: smartpqi: Identify physical devices without issuing INQUIRY") Since the ATA disks do not technically have SAS addresses that is why the output is now 0s. Sorry for the inconvenience, Don Brace
