On Thu, Jul 22, 2021 at 10:52:44AM -0700, Bart Van Assche wrote:
>> - * routines know the command size based on the opcode decode.
>> - *
>> - * The output area is then filled in starting from the command byte.
>> - */
>> -
>> static int ioctl_internal_command(struct scsi_device *sdev, char *cmd,
>> int timeout, int retries)
>> {
>
> How about adding a comment that explains what this function does? How about
> declaring 'cmd' const and adding a comment that it is a pointer to a SCSI
> CDB? How about documenting the unit of 'timeout'?
Not sure there is much of a point for a static function in (pun intended)
fairly static code.
