Re: [patch 16/30] drivers/scsi/aic7xxx_old: Convert to generic boolean-values

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 07 May 2007 14:50:19 -0500
James Bottomley <James.Bottomley@xxxxxxxxxxxx> wrote:

> On Thu, 2007-04-26 at 00:35 -0700, akpm@xxxxxxxxxxxxxxxxxxxx wrote:
> > From: Richard Knutsson <ricknu-0@xxxxxxxxxxxxxx>
> > 
> > Convert:
> > FALSE -> false
> > TRUE  -> true
> 
> NAK'd by maintainer.
> 

I went back and reviewed the previous discussion.  Maintaner's reasons for
NAKing were, and remain wholly specious.

That being said, the patch is moderately wrong (or at least incomplete)
because it does things like:

-            unsigned char done = FALSE;
+            unsigned char done = false;

whereas it should have done

-            unsigned char done = FALSE;
+            bool done = false;

so I'll drop it on those grounds, not on the bogus ones.
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux