Re: [PATCH v2 06/19] scsi: ufs: Remove ufshcd_valid_tag()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2021-07-09 at 13:26 -0700, Bart Van Assche wrote:
> scsi_add_host() allocates shost->can_queue tags. ufshcd_init() sets
> 
> shost->can_queue to hba->nutrs. In other words, we know that tag
> values
> 
> will less than hba->nutrs. Hence remove the checks that verify that
> 
> blk_get_request() returns a tag less than hba->nutrs. This check
> 
> was introduced by commit 14497328b6a6 ("scsi: ufs: verify command tag
> 
> validity").
> 
> 
> 
> Keep the tag >= 0 check because it helps to detect use-after-free
> issues.
> 
> 
> 
> CC: Avri Altman <avri.altman@xxxxxxx>
> 
> Cc: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>
> 
> Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>

Bart,
you need to rebase this patch.

Reviewed-by: Bean Huo <beanhuo@xxxxxxxxxx>




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux