On Fri, May 04, 2007 at 10:59:40PM +0200, Guennadi Liakhovetski wrote:
> cpu_to_le32 endianness conversions in tmscsim.c, followed by
> arithmetic operations don't look correct. Besides, {in,out}[wl]
> already perform the necessary conversions. Further, bus addresses
> of request buffers are guaranteed to be (mapped) under 4G by
> current scsi- and block-layer defaults. This could be explicitly
> enforced by using blk_queue_bounce_limit(), which, however,
> doesn't seem to be the common practice among SCSI drivers.
Looks good to me. If there are structures in dma memory in the driver
it would help to give the __le annotation to get the whole endianess
handling completely right.
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
