On 7/4/21 11:33 PM, Avri Altman wrote: >> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c >> index a34aa6d486c7..37302a8b3937 100644 >> --- a/drivers/scsi/ufs/ufshcd.c >> +++ b/drivers/scsi/ufs/ufshcd.c >> @@ -8736,6 +8736,7 @@ static void ufshcd_vreg_set_lpm(struct ufs_hba >> *hba) >> usleep_range(5000, 5100); >> } >> >> +#ifdef CONFIG_PM > Maybe move this few lines up to include ufshcd_vreg_set_lpm as well? The following call chain requires that ufshcd_vreg_set_lpm() is always available: ufshcd_shutdown() -> ufshcd_suspend() -> ufshcd_vreg_set_lpm(). > Are there any ufs platforms that doesn't use pm management? > Automotive platforms maybe? I'm not sure whether there is any platform on which UFS PM is disabled. My purpose with this patch is to document which code is not used if power management is disabled. Bart.
