On Sat, Jul 03, 2021 at 11:58:33AM -0400, Martin K. Petersen wrote: > - depends on BLK_CGROUP=y > + depends on BLK_CGROUP=y && NVME_FC BLK_CGROUP is a bool, so I think this can simply be: depends on BLK_CGROUP && NVME_FC Otherwise this looks much better: Reviewed-by: Christoph Hellwig <hch@xxxxxx>