Now that the caller of sas_scsi_recover_host(), namely scsi_error_handler(), clears host_eh_scheduled, remove the assignment from sas_scsi_recover_host() that clears this member variable. Cc: Hannes Reinecke <hare@xxxxxxx> Cc: Ming Lei <ming.lei@xxxxxxxxxx> Cc: John Garry <john.garry@xxxxxxxxxx> Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx> --- drivers/scsi/libsas/sas_scsi_host.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/scsi/libsas/sas_scsi_host.c b/drivers/scsi/libsas/sas_scsi_host.c index 95e4d58ab9d4..ae6c273e743e 100644 --- a/drivers/scsi/libsas/sas_scsi_host.c +++ b/drivers/scsi/libsas/sas_scsi_host.c @@ -770,10 +770,8 @@ void sas_scsi_recover_host(struct Scsi_Host *shost) /* check if any new eh work was scheduled during the last run */ spin_lock_irq(&ha->lock); ha->eh_running = false; - if (ha->eh_active == 0) { - shost->host_eh_scheduled = 0; + if (ha->eh_active == 0) retry = false; - } spin_unlock_irq(&ha->lock); if (retry)