Re: [PATCH v2] mpi3mr: Fix W=1 compilation warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Sreekanth,

> -	strncpy(drv_info->os_name, utsname()->sysname, sizeof(drv_info->os_name));
> +	strscpy(drv_info->os_name, utsname()->sysname, sizeof(drv_info->os_name));
>  	drv_info->os_name[sizeof(drv_info->os_name) - 1] = 0;

strscpy() terminates the string.

> -	strncpy(drv_info->os_version, utsname()->release, sizeof(drv_info->os_version));
> +	strscpy(drv_info->os_version, utsname()->release, sizeof(drv_info->os_version));
>  	drv_info->os_version[sizeof(drv_info->os_version) - 1] = 0;

Same here.

>  	strncpy(drv_info->driver_name, MPI3MR_DRIVER_NAME, sizeof(drv_info->driver_name));
>  	strncpy(drv_info->driver_version, MPI3MR_DRIVER_VERSION, sizeof(drv_info->driver_version));

Please convert the remaining strncpy() calls as well.

Thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux