On Thu, May 03, 2007 at 07:17:34AM -0400, Robert P. J. Day wrote: > p.s. "CONFIG_" prefix aside, i would think it's also a bit yucky to > be checking for the definition of a preprocessor symbol that you've > already hardcoded out of existence in the same source file. :-) No, because the way you turn them on (as intended) is to do: perl -pi -e 's/undef/define/ if m/CONFIG_ACORNSCSI_CONSTANTS/' \ drivers/scsi/arm/acornscsi.c (or via your text editor). An alternative way around the issue is to keep a separate patch outside of mainline which patches the additional code and data into the driver. That's far less maintainable, and leads to additional problems. -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
