Himanshu,
The heartbeat check patch attached does the actual validation,
and the same is extended for edif commands too.
Thanks,
Nilesh
> -----Original Message-----
> From: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>
> Sent: Thursday, June 24, 2021 12:17 AM
> To: Nilesh Javali <njavali@xxxxxxxxxxx>; martin.petersen@xxxxxxxxxx
> Cc: linux-scsi@xxxxxxxxxxxxxxx; GR-QLogic-Storage-Upstream <GR-QLogic-
> Storage-Upstream@xxxxxxxxxxx>
> Subject: [EXT] Re: [PATCH v3 10/11] qla2xxx: enable heartbeat validation for
> edif command
>
> External Email
>
> ----------------------------------------------------------------------
>
>
> On 6/23/21 5:26 AM, Nilesh Javali wrote:
> > From: Quinn Tran <qutran@xxxxxxxxxxx>
> >
> > Increment the command and the completion counts.
>
> I don't see enablement of heartbeat validation code in this patch.
>
> Am i missing something?
>
> >
> > Signed-off-by: Quinn Tran <qutran@xxxxxxxxxxx>
> > Signed-off-by: Nilesh Javali <njavali@xxxxxxxxxxx>
> > ---
> > drivers/scsi/qla2xxx/qla_edif.c | 1 +
> > drivers/scsi/qla2xxx/qla_isr.c | 3 +--
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/scsi/qla2xxx/qla_edif.c b/drivers/scsi/qla2xxx/qla_edif.c
> > index 8e730cc882e6..ccbe0e1bfcbc 100644
> > --- a/drivers/scsi/qla2xxx/qla_edif.c
> > +++ b/drivers/scsi/qla2xxx/qla_edif.c
> > @@ -2926,6 +2926,7 @@ qla28xx_start_scsi_edif(srb_t *sp)
> > req->ring_ptr++;
> > }
> >
> > + sp->qpair->cmd_cnt++;
> > /* Set chip new ring index. */
> > wrt_reg_dword(req->req_q_in, req->ring_index);
> >
> > diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
> > index ce4f93fb4d25..e8928fd83049 100644
> > --- a/drivers/scsi/qla2xxx/qla_isr.c
> > +++ b/drivers/scsi/qla2xxx/qla_isr.c
> > @@ -3192,10 +3192,9 @@ qla2x00_status_entry(scsi_qla_host_t *vha,
> struct rsp_que *rsp, void *pkt)
> > return;
> > }
> >
> > - sp->qpair->cmd_completion_cnt++;
> > -
> > /* Fast path completion. */
> > qla_chk_edif_rx_sa_delete_pending(vha, sp, sts24);
> > + sp->qpair->cmd_completion_cnt++;
> >
> > if (comp_status == CS_COMPLETE && scsi_status == 0) {
> > qla2x00_process_completed_request(vha, req, handle);
> >
>
> --
> Himanshu Madhani Oracle Linux Engineering
--- Begin Message ---
- To: Nilesh Javali <njavali@xxxxxxxxxxx>
- Subject: [EXT] Re: [PATCH v2] qla2xxx: add heartbeat check
- From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
- Date: Wed, 23 Jun 2021 01:54:34 +0000
- Cc: "martin.petersen@xxxxxxxxxx" <martin.petersen@xxxxxxxxxx>, "linux-scsi@xxxxxxxxxxxxxxx" <linux-scsi@xxxxxxxxxxxxxxx>, GR-QLogic-Storage-Upstream <GR-QLogic-Storage-Upstream@xxxxxxxxxxx>
- In-reply-to: <20210619052427.6440-1-njavali@marvell.com> (Nilesh Javali's message of "Fri, 18 Jun 2021 22:24:27 -0700")
External Email
----------------------------------------------------------------------
Nilesh,
> Use 'no-op' mailbox command to check and see if FW is still
> responsive.
Applied to 5.14/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
--- End Message ---
