On Mon, Apr 30, 2007 at 04:53:55PM +0200, Olaf Kirch wrote: > I recently ran into an oops that happens because you > can shut down all of iSCSI even though you still have > iSCSI targets mounted. It turned out that iscsi's > scsi_host_template missed a THIS_MODULE, so > reference counting wasn't done properly. Brief > inspection showed that this seems to be a rather > wide-spread problem. Here's a patch to address this. Two comments: - a driver should handle hot unplugs proper, even if THIS_MODULE is set this can happen if the hardware just goes away. - strictly speaking many of the drivers in your patch already set up the owner because scsi_module.c already does it for them. But we try to get rid of scsi_module.c so this is an improvement, you can now remove setting .module in scsi_module.c - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
