在 2021/6/9 21:13, John Garry 写道:
I just noticed that libsas.h already has a prototype for
sas_slave_alloc() - any idea why?
sas_slave_alloc() was implemented in the history and it was removed in
this commit: 9508a66f898d. And it seems the prototype was left over
since then.
.
ok, understood.
So how about backporting this also? I have no idea when the regression
was introduced and prob cannot test as it predates hisi_sas support.
This function before did nothing but initialized the ata port. The
commit removed the function just moved the initialization somewhere
else.
-int sas_slave_alloc(struct scsi_device *scsi_dev)
-{
- struct domain_device *dev = sdev_to_domain_dev(scsi_dev);
-
- if (dev_is_sata(dev))
- return ata_sas_port_init(dev->sata_dev.ap);
-
- return 0;
-}
It looks like it's not related to this issue. And I guess it is
not a regression. This issue only exists when user do a manual scan and
at the same time the device is offlined. Few people will do that actually.
BTW, we also have a dangling prototype for sas_init_ex_attr(), if
someone wants to delete that...
Thanks,
John
.
