On Do, 2021-06-03 at 15:33 +0300, Dan Carpenter wrote:
> The "retval" variable needs to be signed for the error handling to
> work.
>
> Fixes: 7e26e3ea0287 ("scsi: scsi_dh_alua: Check for negative result
> value")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Reviewed-by: Martin Wilck <mwilck@xxxxxxxx>
> ---
> drivers/scsi/device_handler/scsi_dh_alua.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c
> b/drivers/scsi/device_handler/scsi_dh_alua.c
> index 7baee18ebd03..37d06f993b76 100644
> --- a/drivers/scsi/device_handler/scsi_dh_alua.c
> +++ b/drivers/scsi/device_handler/scsi_dh_alua.c
> @@ -518,7 +518,8 @@ static int alua_rtpg(struct scsi_device *sdev,
> struct alua_port_group *pg)
> int len, k, off, bufflen = ALUA_RTPG_SIZE;
> int group_id_old, state_old, pref_old, valid_states_old;
> unsigned char *desc, *buff;
> - unsigned err, retval;
> + unsigned err;
> + int retval;
> unsigned int tpg_desc_tbl_off;
> unsigned char orig_transition_tmo;
> unsigned long flags;
