On 02/06/2021 14:30, Ming Lei wrote:
scsi_host_dev_release() only works around for us by freeing dev_name(&shost->shost_dev) when host state is SHOST_CREATED. After host state is changed to SHOST_RUNNING, scsi_host_dev_release() doesn't do that any more. So fix the issue by put .shost_dev in failure path if host state becomes running, meantime move get_device(&shost->shost_gendev) before device_add(&shost->shost_dev), so that scsi_host_cls_release() can put this reference. Reported-by: John Garry<john.garry@xxxxxxxxxx> Cc: Bart Van Assche<bvanassche@xxxxxxx> Cc: Hannes Reinecke<hare@xxxxxxx> Signed-off-by: Ming Lei<ming.lei@xxxxxxxxxx>
Reviewed-by: John Garry <john.garry@xxxxxxxxxx>
