> On Jun 2, 2021, at 1:01 AM, Javed Hasan <jhasan@xxxxxxxxxxx> wrote:
>
> Hello Himanshu,
>
> There are no warnings resurfaced after this fix because second patch of this series taking care of those compiler warnings.
> Verified using "make W=1" Command.
>
In that case, Please resubmit with Fixes tag and Cc to stable. You can keep my R-b.
Thanks.
> Regards
> Javed
>
> -----Original Message-----
> From: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>
> Sent: Tuesday, June 1, 2021 11:38 PM
> To: Javed Hasan <jhasan@xxxxxxxxxxx>; martin.petersen@xxxxxxxxxx
> Cc: linux-scsi@xxxxxxxxxxxxxxx; GR-QLogic-Storage-Upstream <GR-QLogic-Storage-Upstream@xxxxxxxxxxx>
> Subject: [EXT] Re: [PATCH 1/2] scsi: fc: Corrected RHBA attributes length
>
> External Email
>
> ----------------------------------------------------------------------
>
>
> On 6/1/21 12:52 PM, Himanshu Madhani wrote:
>>
>>
>> On 6/1/21 12:21 PM, Javed Hasan wrote:
>>> -As per document of FC-GS-5, attribute lengths of node_name
>>> and manufacturer should in range of "4 to 64 Bytes" only.
>>>
>>> Signed-off-by: Javed Hasan <jhasan@xxxxxxxxxxx>
>>>
>>> ---
>>> include/scsi/fc/fc_ms.h | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/include/scsi/fc/fc_ms.h b/include/scsi/fc/fc_ms.h index
>>> 9e273fed0a85..800d53dc9470 100644
>>> --- a/include/scsi/fc/fc_ms.h
>>> +++ b/include/scsi/fc/fc_ms.h
>>> @@ -63,8 +63,8 @@ enum fc_fdmi_hba_attr_type {
>>> * HBA Attribute Length
>>> */
>>> #define FC_FDMI_HBA_ATTR_NODENAME_LEN 8 -#define
>>> FC_FDMI_HBA_ATTR_MANUFACTURER_LEN 80 -#define
>>> FC_FDMI_HBA_ATTR_SERIALNUMBER_LEN 80
>>> +#define FC_FDMI_HBA_ATTR_MANUFACTURER_LEN 64 #define
>>> +FC_FDMI_HBA_ATTR_SERIALNUMBER_LEN 64
>>> #define FC_FDMI_HBA_ATTR_MODEL_LEN 256
>>> #define FC_FDMI_HBA_ATTR_MODELDESCR_LEN 256
>>> #define FC_FDMI_HBA_ATTR_HARDWAREVERSION_LEN 256
>>>
>>
>> Looks good.
>>
>> Reviewed-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>
>>
>
> I just noticed that this patch is basically reverting commit e721eb0616f62e766882b80fd3433b80635abd5f ("scsi: scsi_transport_fc:
> Match HBA Attribute Length with HBAAPI V2.0 definitions").
>
> Have you verified that the compiler warnings do not resurface with your patch? if you see that compiler warning, please fix appropriately and resubmit this patch.
>
> --
> Himanshu Madhani Oracle Linux Engineering
--
Himanshu Madhani Oracle Linux Engineering
