get_device(&shost->shost_gendev) is called in scsi_add_host_with_dma(), but its counter pair isn't called in the failure path, so fix it by calling put_device(&shost->shost_gendev) in its failure path. Reported-by: John Garry <john.garry@xxxxxxxxxx> Cc: Bart Van Assche <bvanassche@xxxxxxx> Cc: Hannes Reinecke <hare@xxxxxxx> Signed-off-by: Ming Lei <ming.lei@xxxxxxxxxx> --- drivers/scsi/hosts.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c index ea50856cb203..492b64f349e1 100644 --- a/drivers/scsi/hosts.c +++ b/drivers/scsi/hosts.c @@ -295,6 +295,7 @@ int scsi_add_host_with_dma(struct Scsi_Host *shost, struct device *dev, * scsi_host_dev_release, so not free them in the failure path */ out_del_dev: + put_device(&shost->shost_gendev); device_del(&shost->shost_dev); out_del_gendev: device_del(&shost->shost_gendev); -- 2.29.2
