> -----Original Message-----
> From: Alice <alice.chao@xxxxxxxxxxxx>
> Sent: 27 May 2021 21:28
> To: stanley.chu@xxxxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx;
> martin.petersen@xxxxxxxxxx; avri.altman@xxxxxxx;
> alim.akhtar@xxxxxxxxxxx; jejb@xxxxxxxxxxxxx
> Cc: wsd_upstream@xxxxxxxxxxxx; peter.wang@xxxxxxxxxxxx; chun-
> hung.wu@xxxxxxxxxxxx; alice.chao@xxxxxxxxxxxx;
> jonathan.hsu@xxxxxxxxxxxx; powen.kao@xxxxxxxxxxxx;
> cc.chou@xxxxxxxxxxxx; chaotian.jing@xxxxxxxxxxxx;
> jiajie.hao@xxxxxxxxxxxx
> Subject: [PATCH 1/1] scsi: ufs-mediatek: Fix HWReset timing
>
> From: "Alice.Chao" <alice.chao@xxxxxxxxxxxx>
>
> HCI disable before HW Reset.
> Because of the property of mtk ufshci,
> we need to change reset flow to avoid potential issues.
>
Please re-format the commit message and mention few wards about potential
issues.
> Change-Id: I3eb917fd2953b58dcf7e021286d1de71c9232cfb
Hmm, run a checkpatch before submitting any patch.
> Signed-off-by: Alice.Chao <alice.chao@xxxxxxxxxxxx>
> CR-Id: ALPS05728133
What are these ID? Please remove.
> Feature: UFS(Universal Flash Storage)
Please check Documentation/process/submitting-patches.rst, before submitting
patches.
> ---
> drivers/scsi/ufs/ufs-mediatek.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/scsi/ufs/ufs-mediatek.c
b/drivers/scsi/ufs/ufs-mediatek.c
> index a981f261b304..c62603ed3d33 100644
> --- a/drivers/scsi/ufs/ufs-mediatek.c
> +++ b/drivers/scsi/ufs/ufs-mediatek.c
> @@ -846,6 +846,9 @@ static int ufs_mtk_device_reset(struct ufs_hba *hba)
> {
> struct arm_smccc_res res;
>
> + /* disable hba before device reset */
> + ufshcd_hba_stop(hba);
> +
> ufs_mtk_device_reset_ctrl(0, res);
>
> /*
> --
> 2.18.0
