On 5/23/21 10:57 AM, Mike Christie wrote:
> We have a ref to the task being aborted, so SCp.ptr will never be NULL. We
> need to use iscsi_task_is_completed to check for the completed state.
>
> Signed-off-by: Mike Christie <michael.christie@xxxxxxxxxx>
> ---
> drivers/scsi/libiscsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
> index 94abb093098d..8222db4f8fef 100644
> --- a/drivers/scsi/libiscsi.c
> +++ b/drivers/scsi/libiscsi.c
> @@ -2338,7 +2338,7 @@ int iscsi_eh_abort(struct scsi_cmnd *sc)
> iscsi_conn_failure(conn, ISCSI_ERR_SCSI_EH_SESSION_RST);
> goto failed_unlocked;
> case TMF_NOT_FOUND:
> - if (!sc->SCp.ptr) {
> + if (iscsi_task_is_completed(task)) {
> session->tmf_state = TMF_INITIAL;
> memset(hdr, 0, sizeof(*hdr));
> /* task completed before tmf abort response */
>
Reviewed-by: Lee Duncan <lduncan@xxxxxxxx>
