On Wed, 25 Apr 2007 02:49:46 +0200 Olivier Galibert <galibert@xxxxxxxxx> wrote: > On Tue, Apr 24, 2007 at 01:53:27PM -0700, Kristen Carlson Accardi wrote: > > Check to see if an ATAPI device supports Asynchronous Notification. > > If so, enable it. > > > > changes from last version: > > * fix typo in ata_id_has_AN and make word 76 test more clear > > * If we fail to set the AN feature, just print a warning and continue > > > > Signed-off-by: Kristen Carlson Accardi <kristen.c.accardi@xxxxxxxxx> > > > > @@ -299,6 +305,8 @@ struct ata_taskfile { > > #define ata_id_queue_depth(id) (((id)[75] & 0x1f) + 1) > > #define ata_id_removeable(id) ((id)[0] & (1 << 7)) > > #define ata_id_has_dword_io(id) ((id)[50] & (1 << 0)) > > +#define ata_id_has_AN(id) \ > > + (((id[76] != 0x0000) && (id[76] != 0xffff)) && ((id)[78] & (1 << 5))) > > (id)[76] I guess ? Sorry for being a pain :/ > > OG. > Ok - I'll fix that. Thank you for being a pain :), I really appreciate the time you are taking to review my patches. - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html