Re: [PATCH -next] scsi: qedf: use vzalloc() instead of vmalloc()/memset(0)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 5/18/21 8:20 AM, Yang Yingliang wrote:
Use vzalloc() instead of vmalloc() and memset(0) to simpify
the code.

Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
---
  drivers/scsi/qedf/qedf_dbg.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/scsi/qedf/qedf_dbg.c b/drivers/scsi/qedf/qedf_dbg.c
index e0387e495261..0d2aed82882a 100644
--- a/drivers/scsi/qedf/qedf_dbg.c
+++ b/drivers/scsi/qedf/qedf_dbg.c
@@ -106,11 +106,10 @@ qedf_dbg_info(struct qedf_dbg_ctx *qedf, const char *func, u32 line,
  int
  qedf_alloc_grc_dump_buf(u8 **buf, uint32_t len)
  {
-		*buf = vmalloc(len);
+		*buf = vzalloc(len);
  		if (!(*buf))
  			return -ENOMEM;
- memset(*buf, 0, len);
  		return 0;
  }

Looks Good.

Reviewed-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>

--
Himanshu Madhani                                Oracle Linux Engineering



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux