On 5/12/21 10:55 PM, Can Guo wrote:
> If PM requests fail during runtime suspend/resume, RPM framework saves the
> error to dev->power.runtime_error. Before the runtime_error gets cleared,
> runtime PM on this specific device won't work again, leaving the device
> in either suspended or active state permanently.
>
> When task abort happens to a PM request sent during runtime suspend/resume,
> even if it can be successfully aborted, RPM framework anyways saves the
> (TIMEOUT) error. But we want more and we can do better - let error handling
> recover and clear the runtime_error. So, let PM requests take the fast
> abort path in ufshcd_abort().
The only RQF_PM requests I know of are START STOP UNIT and SYNCHRONIZE
CACHE. Are there devices for which these commands can time out or do
these commands perhaps only time out as the result of error injection?
> - if (lrbp->lun == UFS_UPIU_UFS_DEVICE_WLUN) {
> + if (lrbp->lun == UFS_UPIU_UFS_DEVICE_WLUN ||
> + (cmd->request->rq_flags & RQF_PM)) {
Which are the RQF_PM commands that are not sent to a WLUN? Are these
START STOP UNIT and SYNCHRONIZE CACHE only?
Thanks,
Bart.
