> > > + if (ufshcd_is_link_off(hba)) > > > + ufs_mtk_device_reset_ctrl(0, res); > > According to your commit log, you should call reset just before > > ufs_mtk_vreg_set_lpm, or turn phy off, whichever turn off vcc - > > Few lines above. > > > > Thanks, > > Avri > > ufs_mtk_vreg_set_lpm only set vccq2 power mode to lpm, dose't trun off > vccq2.And turn phy off is also turn off vcc, dose't turn off vccq2. > RST_N keep high is no problem when we trun off vcc and vccq2 keep on. > But RST_N will got problem if we trun off vccq2. > (RST_N signal should be between VSS(Ground) and VCCQ/VCCQ2) > Here set RST_N to low is after shut down pm set link off, and before > shutdown pm turn off vccq2. OK. Thanks for clarifying this. Thanks, Avri > > Thanks > Peter > > > > > > + > > > return 0; > > > fail: > > > /* > > > -- > > > 1.7.9.5 > >
