On Wed, 2021-05-12 at 17:00 -0700, Bart Van Assche wrote: > On 5/12/21 4:23 PM, James Bottomley wrote: > > No, we support physical sector sizes up to 4k. The logical block > > size internal to the kernel and the block layer is always 512. I > > can see the utility in using consistent naming to the block layer, > > but I can't see that logical block address is confusing ... > > especially now manufacturers seem all to have aligned on 512 for > > the logical block size even when it's usually 4k physical. > > Are we talking about the same? Just below the code that I included in > my previous email there is the following line: > > blk_queue_logical_block_size(sdp->request_queue, sector_size); > > where sector_size is the logical block size reported by the READ > CAPACITY command and has a value between 512 and 4096. That was for devices from before the industry standardised, which are getting harder and harder to find (In fact I'm thinking of making a NFT out of my last 4k logical/physical disk). But it didn't alter the fact that the kernel internal block size is 512. James
