Hi Nilesh, > On May 7, 2021, at 8:25 AM, Nilesh Javali <njavali@xxxxxxxxxxx> wrote: > > > Add Encryption for Data In Flight (EDIF) support. This feature allows > data of 2 end points to be encrypted. A user application is required > to play the role of authentication for both sides. On completion of > authentication, user app shall provide a set of Tx/Rx keys and spi's > for HW to program into the session. > > modprobe qla2xxx ql2xsecenable=1 > > Signed-off-by: Larry Wisneski <Larry.Wisneski@xxxxxxxxxxx> > Signed-off-by: Duane Grigsby <duane.grigsby@xxxxxxxxxxx> > Signed-off-by: Rick Hicksted Jr <rhicksted@xxxxxxxxxxx> > Signed-off-by: Quinn Tran <qutran@xxxxxxxxxxx> > Signed-off-by: Nilesh Javali <njavali@xxxxxxxxxxx> While you are fixing kernel test robot warnings, I’ll like to see this patch split into logical changes. It’s very hard to review 5K lines of changes into single patch. Also while you are at it, Please provide detail description of the feature and how user will use this feature. -- Himanshu Madhani Oracle Linux Engineering