On 5/3/21 8:03 AM, Hannes Reinecke wrote: > +/** > + * scsi_device_is_host_dev - Check if a scsi device is a host device > + * @sdev: SCSI device to test > + * > + * Returns: true if @sdev is a host device, false otherwise > + */ > +bool scsi_device_is_host_dev(struct scsi_device *sdev) > +{ > + return ((const unsigned char *)sdev->inquiry == scsi_null_inquiry); > +} No parentheses around the expression in a return statement please. > +EXPORT_SYMBOL_GPL(scsi_device_is_host_dev); Does this mean that this function will be used outside the SCSI core? Thanks, Bart.