Use the sysfs configurable timeout when issuing a START_UNIT command from the scsi error handler. This is needed for devices which take longer than thirty seconds to respond to the start unit. The problem was observed when sending a start unit to a disk array device in an ipr RAID adapter, which results in the adapter firmware sending potentially multiple commands to physical devices as a result of this command, which ended up timing out sometimes. This patch does not change the default value used for this command. Signed-off-by: Brian King <brking@xxxxxxxxxxxxxxxxxx> --- James, This patch applies on top of the start unit retry patch referenced here: http://marc.info/?l=linux-scsi&m=117544524204024&w=2 This patch isn't in scsi-misc yet, but I assume it is in your queue. Thanks, Brian --- linux-2.6-bjking1/drivers/scsi/scsi_error.c | 3 +-- 1 files changed, 1 insertion(+), 2 deletions(-) diff -puN drivers/scsi/scsi_error.c~scsi_eh_stu_timeout drivers/scsi/scsi_error.c --- linux-2.6/drivers/scsi/scsi_error.c~scsi_eh_stu_timeout 2007-04-19 13:48:37.000000000 -0500 +++ linux-2.6-bjking1/drivers/scsi/scsi_error.c 2007-04-19 13:48:37.000000000 -0500 @@ -38,7 +38,6 @@ #include "scsi_logging.h" #define SENSE_TIMEOUT (10*HZ) -#define START_UNIT_TIMEOUT (30*HZ) /* * These should *probably* be handled by the host itself. @@ -927,7 +926,7 @@ static int scsi_eh_try_stu(struct scsi_c for (i = 0; rtn == NEEDS_RETRY && i < 2; i++) rtn = scsi_send_eh_cmnd(scmd, stu_command, 6, - START_UNIT_TIMEOUT, 0); + scmd->device->timeout, 0); if (rtn == SUCCESS) return 0; _ - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
