On 4/26/21 5:21 PM, Christoph Hellwig wrote: > On Fri, Apr 23, 2021 at 01:39:15PM +0200, Hannes Reinecke wrote: >> Set DID_TIME_OUT instead of DRIVER_TIMEOUT when a command >> is finally marked as failed after error recovery. > > This seems like something that we need to propagating to userspace > through the various sg interfaces as applications could rely on the > bit. > That would be highly surprising. That particular bit is only ever set if a timeout has triggered, but the driver did not set any other status. Which again does _strongly_ depend on the driver; there is not consensus what the status should be for a timed out command. So if userspace ever saw this value it would be strongly driver depended, and there was never any intention that any particular driver _would_ set this flag. In short: if it ever was set, it was by accident. Hence userspace shouldn't check for it. So I don't think we need to worry about that. Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@xxxxxxx +49 911 74053 688 SUSE Software Solutions Germany GmbH, 90409 Nürnberg GF: F. Imendörffer, HRB 36809 (AG Nürnberg)
