Re: [PATCH 16/39] scsi: add translate_msg_byte()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Hannes Reinecke <hare@xxxxxxx>
Subject: Re: [PATCH 16/39] scsi: add translate_msg_byte()
From: Christoph Hellwig <hch@xxxxxx>
Date: Mon, 26 Apr 2021 17:24:42 +0200
Cc: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, James Bottomley <james.bottomley@xxxxxxxxxxxxxxxxxxxxx>, linux-scsi@xxxxxxxxxxxxxxx, Bart van Assche <bvanassche@xxxxxxx>
In-reply-to: <20210423113944.42672-17-hare@suse.de>
User-agent: Mutt/1.5.17 (2007-11-01)

> +static inline void translate_msg_byte(struct scsi_cmnd *cmd, u8 msg)

I think a comment describing the function would be very helpful.
Also maybe scsi_message_to_host_byte might be a more descriptive name?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Follow-Ups:
- Re: [PATCH 16/39] scsi: add translate_msg_byte()
  - From: Hannes Reinecke

References:
- [RFC PATCHv2 00/39] SCSI result cleanup, part 2
  - From: Hannes Reinecke
- [PATCH 16/39] scsi: add translate_msg_byte()
  - From: Hannes Reinecke

Prev by Date: Re: [PATCH 15/39] scsi: add get_{status,host}_byte() accessor function
Next by Date: Re: [PATCH 17/39] dc395: use standard macros to set SCSI result
Previous by thread: Re: [PATCH 16/39] scsi: add translate_msg_byte()
Next by thread: Re: [PATCH 16/39] scsi: add translate_msg_byte()
Index(es):
- Date
- Thread

[Index of Archives] [SCSI Target Devel] [Linux SCSI Target Infrastructure] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Linux IIO] [Samba] [Device Mapper]

Powered by Linux