On 4/23/21 4:39 AM, Hannes Reinecke wrote: > diff --git a/drivers/target/target_core_pscsi.c b/drivers/target/target_core_pscsi.c > index dac44caf77a3..7e5e4ab3c126 100644 > --- a/drivers/target/target_core_pscsi.c > +++ b/drivers/target/target_core_pscsi.c > @@ -1044,7 +1044,7 @@ static void pscsi_req_done(struct request *req, blk_status_t status) > struct se_cmd *cmd = req->end_io_data; > struct pscsi_plugin_task *pt = cmd->priv; > int result = scsi_req(req)->result; > - u8 scsi_status = status_byte(result) << 1; > + u8 scsi_status = (result & 0xff); I don't think that the parentheses are necessary in the above expression. Anyway: Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>