On 4/23/21 4:39 AM, Hannes Reinecke wrote: > Original the SCSI subsystem has been using 'special' SCSI status ^^^^^^^^ Originally? > +/* > + * Original linux SCS Status codes. They are shifted 1 bit right ^^^ SCSI? > + * from those found in the SCSI standards. > + */ > + > +#define GOOD 0x00 > +#define CHECK_CONDITION 0x01 > +#define CONDITION_GOOD 0x02 > +#define BUSY 0x04 > +#define INTERMEDIATE_GOOD 0x08 > +#define INTERMEDIATE_C_GOOD 0x0a > +#define RESERVATION_CONFLICT 0x0c > +#define COMMAND_TERMINATED 0x11 > +#define QUEUE_FULL 0x14 > +#define ACA_ACTIVE 0x18 > +#define TASK_ABORTED 0x20 > + > +/* Obsolete status_byte() declaration */ > +#define status_byte(result) (((result) >> 1) & 0x7f) If the above comments are addressed, please add: Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>