On 4/23/21 4:39 AM, Hannes Reinecke wrote:
> Add a helper function scsi_status_is_check_condtion() to
^^^^^^^^ typo
> encapsulate the frequent checks for SAM_STAT_CHECK_CONDITION.
[ ... ]
> +/** scsi_status_is_check_condition - check the status return.
> + *
> + * @status: the status passed up from the driver (including host and
> + * driver components)
> + *
> + * This returns true if the status code is SAM_STAT_CHECK_CONDITION.
> + */
Shouldn't the function name and the description appear on the second
line of the kernel-doc header?
> +static inline int scsi_status_is_check_condition(int status)
> +{
> + if (status < 0)
> + return false;
> + status &= 0xfe;
> + return (status == SAM_STAT_CHECK_CONDITION);
> +}
No parentheses around the expression in a return statement please.
Thanks,
Bart.
