> -----Original Message----- > From: Hisashi Hifumi [mailto:hifumi.hisashi@xxxxxxxxxxxxx] > Sent: Wednesday, April 18, 2007 2:03 AM > To: Miller, Mike (OS Dev); akpm@xxxxxxxxxxxxxxxxxxxx > Subject: [PATCH] cciss: Fix warnings during compilation under > 32bit environment > > > Hi. > > I fixed following warnings. > > drivers/block/cciss.c: In function `do_cciss_request': > drivers/block/cciss.c:2555: warning: right shift count >= > width of type > drivers/block/cciss.c:2556: warning: right shift count >= > width of type > drivers/block/cciss.c:2557: warning: right shift count >= > width of type > drivers/block/cciss.c:2558: warning: right shift count >= > width of type > > > Signed-off-by :Hisashi Hifumi <hifumi.hisashi@xxxxxxxxxxxxx> Nak. You still haven't told where you saw these warnings. What compiler are you using? I do not see these in my 32-bit environment. mikem > > > --- linux-2.6.21-rc7.org/drivers/block/cciss.c 2007-04-17 > 16:36:02.000000000 +0900 > +++ linux-2.6.21-rc7/drivers/block/cciss.c 2007-04-17 > 16:25:53.000000000 +0900 > @@ -2552,10 +2552,10 @@ static void do_cciss_request(request_que > } else { > c->Request.CDBLen = 16; > c->Request.CDB[1]= 0; > - c->Request.CDB[2]= (start_blk >> 56) & 0xff; //MSB > - c->Request.CDB[3]= (start_blk >> 48) & 0xff; > - c->Request.CDB[4]= (start_blk >> 40) & 0xff; > - c->Request.CDB[5]= (start_blk >> 32) & 0xff; > + c->Request.CDB[2]= sizeof(start_blk) > 4 ? > (start_blk >> 56) & 0xff : 0; //MSB > + c->Request.CDB[3]= sizeof(start_blk) > 4 ? > (start_blk >> 48) & 0xff : 0; > + c->Request.CDB[4]= sizeof(start_blk) > 4 ? > (start_blk >> 40) & 0xff : 0; > + c->Request.CDB[5]= sizeof(start_blk) > 4 ? > (start_blk >> 32) & 0xff : > +0; > c->Request.CDB[6]= (start_blk >> 24) & 0xff; > c->Request.CDB[7]= (start_blk >> 16) & 0xff; > c->Request.CDB[8]= (start_blk >> 8) & 0xff; > > > > Thanks, > - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
