On 4/22/21 10:27 AM, Maciej W. Rozycki wrote: > On Wed, 21 Apr 2021, Khalid Aziz wrote: > >>> Verifying actual ISA operations (third-party DMA, etc.) cannot be made >>> this way, but as I understand the issue there is merely with passing data >>> structures around and that may not require too much attention beyond >>> getting things syntactically correct, which I gather someone forgot to do >>> with a change made a while ago. So that should be doable as well. >> >> In theory this sounds reasonable, but without being able to test with a >> real hardware I would be concerned about making this change. > > Sometimes you have little choice really and that would be less disruptive > than dropping support altogether. Even if there's a small issue somewhere > it's easier to fix by a competent developer who actually gets the hands on > a piece of hardware than bringing back old code that has been removed and > consequently not updated according to internal API evolution, etc. We are talking about removing support for BT-445S with firmware version older than 3.37. That is a very specific case. To continue support for this very specific case, we have to add new code to use local bounce buffer and we have no hardware to verify this new code. This will be new code whether we add it now or later after we find someone even has this very old card with old firmware. I would prefer to remove support for now and add new code to add support for firmware version older than 3.37 back only if there is a need later. For now anyone who is using a BT-445S and has updated firmware on their card will not see a change. -- Khalid
