Re: [PATCH v3 15/24] mpi3mr: allow certain commands during pci-remove hook

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> On Apr 19, 2021, at 6:01 AM, Kashyap Desai <kashyap.desai@xxxxxxxxxxxx> wrote:
> 
> This patch allows SSU and Sync Cache commands to be sent to the controller
> instead of driver returning DID_NO_CONNECT during driver unload to flush
> any cached data from the drive.
> 
> Signed-off-by: Kashyap Desai <kashyap.desai@xxxxxxxxxxxx>
> Reviewed-by: Hannes Reinecke <hare@xxxxxxx>
> Reviewed-by: Tomas Henzl <thenzl@xxxxxxxxxx>
> 
> Cc: sathya.prakash@xxxxxxxxxxxx
> ---
> drivers/scsi/mpi3mr/mpi3mr_os.c | 24 +++++++++++++++++++++++-
> 1 file changed, 23 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/mpi3mr/mpi3mr_os.c b/drivers/scsi/mpi3mr/mpi3mr_os.c
> index 99a60e6777d5..ac30699c7d69 100644
> --- a/drivers/scsi/mpi3mr/mpi3mr_os.c
> +++ b/drivers/scsi/mpi3mr/mpi3mr_os.c
> @@ -2786,6 +2786,27 @@ static int mpi3mr_target_alloc(struct scsi_target *starget)
> 	return retval;
> }
> 
> +
> +/**
> + * mpi3mr_allow_scmd_to_fw - Command is allowed during shutdown
> + * @scmd: SCSI Command reference
> + *
> + * Checks whether a CDB is allowed during shutdown or not.
> + *
> + * Return: TRUE for allowed commands, FALSE otherwise.
> + */
> +
> +inline bool mpi3mr_allow_scmd_to_fw(struct scsi_cmnd *scmd)
> +{
> +	switch (scmd->cmnd[0]) {
> +	case SYNCHRONIZE_CACHE:
> +	case START_STOP:
> +		return true;
> +	default:
> +		return false;
> +	}
> +}
> +
> /**
>  * mpi3mr_qcmd - I/O request despatcher
>  * @shost: SCSI Host reference
> @@ -2821,7 +2842,8 @@ static int mpi3mr_qcmd(struct Scsi_Host *shost,
> 		goto out;
> 	}
> 
> -	if (mrioc->stop_drv_processing) {
> +	if (mrioc->stop_drv_processing &&
> +	    !(mpi3mr_allow_scmd_to_fw(scmd))) {
> 		scmd->result = DID_NO_CONNECT << 16;
> 		scmd->scsi_done(scmd);
> 		goto out;
> -- 
> 2.18.1
> 

Looks Good.

Reviewed-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>

--
Himanshu Madhani	 Oracle Linux Engineering





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux