On 4/21/21 10:47 AM, Hannes Reinecke wrote:
Use accessors to set the SCSI result.
Signed-off-by: Hannes Reinecke <hare@xxxxxxx>
---
drivers/scsi/NCR5380.c | 28 ++++++++++++++--------------
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c
index d7594b794d3c..855edda9db41 100644
--- a/drivers/scsi/NCR5380.c
+++ b/drivers/scsi/NCR5380.c
@@ -538,7 +538,7 @@ static void complete_cmd(struct Scsi_Host *instance,
if (hostdata->sensing == cmd) {
/* Autosense processing ends here */
- if (status_byte(cmd->result) != GOOD) {
+ if (get_status_byte(cmd) != SAM_STAT_GOOD) {
scsi_eh_restore_cmnd(cmd, &hostdata->ses);
} else {
scsi_eh_restore_cmnd(cmd, &hostdata->ses);
Do all SCSI devices from the nineties report SCSI status values with the
lower bit set to 0? If so, can the status_byte() macro be removed entirely?
Thanks,
Bart.
