[PATCH 025/117] acornscsi: Annotate fallthrough

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This patch suppresses the following compiler warning:

In file included from ./include/linux/bitops.h:32:0,
                 from ./include/linux/kernel.h:11,
                 from ./include/linux/list.h:9,
                 from ./include/linux/module.h:12,
                 from drivers/scsi/arm/acornscsi.c:116:
drivers/scsi/arm/acornscsi.c: In function 'acornscsi_abort':
./arch/arm/include/asm/bitops.h:181:55: warning: this statement may fall through [-Wimplicit-fallthrough=]
  (__builtin_constant_p(nr) ? ____atomic_##name(nr, p) : _##name(nr,p))
  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
./arch/arm/include/asm/bitops.h:190:27: note: in expansion of macro 'ATOMIC_BITOP'
 #define clear_bit(nr,p)   ATOMIC_BITOP(clear_bit,nr,p)
                           ^~~~~~~~~~~~
drivers/scsi/arm/acornscsi.c:2667:3: note: in expansion of macro 'clear_bit'
   clear_bit(SCpnt->device->id * 8 +
   ^~~~~~~~~
drivers/scsi/arm/acornscsi.c:2675:2: note: here
  case res_success:
  ^~~~

Cc: Russell King <linux@xxxxxxxxxxxxxxx>
Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>
---
 drivers/scsi/arm/acornscsi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/scsi/arm/acornscsi.c b/drivers/scsi/arm/acornscsi.c
index 248a5bfad153..912828d1dcad 100644
--- a/drivers/scsi/arm/acornscsi.c
+++ b/drivers/scsi/arm/acornscsi.c
@@ -2664,6 +2664,7 @@ int acornscsi_abort(struct scsi_cmnd *SCpnt)
 //#endif
 		clear_bit(SCpnt->device->id * 8 +
 			  (u8)(SCpnt->device->lun & 0x7), host->busyluns);
+		fallthrough;
 
 	/*
 	 * We found the command, and cleared it out.  Either



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux