Hi Mike, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on mkp-scsi/for-next] [also build test WARNING on scsi/for-next rdma/for-next v5.12-rc7 next-20210415] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Mike-Christie/scsi-libicsi-and-qedi-tmf-fixes/20210414-072516 base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next config: x86_64-randconfig-a015-20210415 (attached as .config) compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 6a18cc23efad410db48a3ccfc233d215de7d4cb9) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # https://github.com/0day-ci/linux/commit/8f3fc14a13ee50e57e645238aad4a5177e097c10 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Mike-Christie/scsi-libicsi-and-qedi-tmf-fixes/20210414-072516 git checkout 8f3fc14a13ee50e57e645238aad4a5177e097c10 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): >> drivers/scsi/qedi/qedi_iscsi.c:1401:19: warning: result of comparison of constant -1 with expression of type 'u16' (aka 'unsigned short') is always true [-Wtautological-constant-out-of-range-compare] if (cmd->task_id != -1) ~~~~~~~~~~~~ ^ ~~ 1 warning generated. vim +1401 drivers/scsi/qedi/qedi_iscsi.c 1386 1387 static void qedi_cleanup_task(struct iscsi_task *task) 1388 { 1389 struct qedi_cmd *cmd; 1390 1391 if (task->state == ISCSI_TASK_PENDING) { 1392 QEDI_INFO(NULL, QEDI_LOG_IO, "Returning ref_cnt=%d\n", 1393 refcount_read(&task->refcount)); 1394 return; 1395 } 1396 1397 if (task->sc) 1398 qedi_iscsi_unmap_sg_list(task->dd_data); 1399 1400 cmd = task->dd_data; > 1401 if (cmd->task_id != -1) 1402 qedi_clear_task_idx(iscsi_host_priv(task->conn->session->host), 1403 cmd->task_id); 1404 1405 cmd->task_id = -1; 1406 cmd->scsi_cmd = NULL; 1407 } 1408 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
