From: kernel test robot <lkp@xxxxxxxxx> drivers/scsi/libiscsi.c:1737:11-12: WARNING: return of 0/1 in function 'iscsi_eh_running' with return type bool Return statements in functions returning bool should use true/false instead of 1/0. Generated by: scripts/coccinelle/misc/boolreturn.cocci CC: Mike Christie <michael.christie@xxxxxxxxxx> Reported-by: kernel test robot <lkp@xxxxxxxxx> Signed-off-by: kernel test robot <lkp@xxxxxxxxx> --- url: https://github.com/0day-ci/linux/commits/Mike-Christie/scsi-libicsi-and-qedi-tmf-fixes/20210414-072516 base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next libiscsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/scsi/libiscsi.c +++ b/drivers/scsi/libiscsi.c @@ -1734,7 +1734,7 @@ static bool iscsi_eh_running(struct iscs switch (ISCSI_TM_FUNC_VALUE(tmf)) { case ISCSI_TM_FUNC_LOGICAL_UNIT_RESET: if (sc->device->lun != scsilun_to_int(&tmf->lun)) - return 0; + return false; ISCSI_DBG_EH(conn->session, "Requeue cmd sent during LU RESET processing.\n");
