Both scsi/qla2xxx/qla_init.c and scsi/qla4xxx/ql4_init.c use pci_set_mwi() like this: mwi = 0; if (pci_set_mwi(ha->pdev)) mwi = PCI_COMMAND_INVALIDATE; and then go on to set the PCI_COMMAND "word" based on that value. I don't quite get it. pci_set_mwi() returns 0 for success or negative for error... so if pci_set_mwi() fails, the qla init code still tries to set the PCI_COMMAND_INVALIDATE bit in the PCI_COMMAND word? The logic looks inverted to me. What am I overlooking? Thanks. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
