Good morning Laurence. I guess we still need Martin's opinion, but considering how many customers I've had to help get past this, I'd welcome an easy way out. Thanks. Reviewed-by: John Pittman <jpittman@xxxxxxxxxx> On Fri, Apr 9, 2021 at 4:59 PM Bart Van Assche <bvanassche@xxxxxxx> wrote: > > On 4/8/21 8:56 AM, Laurence Oberman wrote: > > Hi Bart the original macro is the same so I think best not to change it > > other than the wrapper I added. What are your thoughts. > > Hi Laurence, > > Since the current definition is not optimal from a source code > readability standpoint and since this patch changes the sd_printk() > definition I think this is a great opportunity to improve that > definition. Please note that I don't have a strong opinion about this. > > Bart. >