Re: [RFC v2 5/7] scsi: iscsi: fix some of the bugs with Perform connection failure entirely in kernel space

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/11/21 7:50 PM, Mike Christie wrote:
> +			/*
> +			 * For offload boot support where iscsid is restarted
> +			 * during the pivot root stage, the ep will be instact
> +			 * here when the new iscsid instance starts up and
> +			 * reconnects.
> +			 */
> +			mutex_unlock(&conn->ep_mutex);
> +			iscsi_if_ep_disconnect(transport, ep_handle);
> +			mutex_lock(&conn->ep_mutex);
Hey Khazhy,

The above chunk should have just been a call to iscsi_ep_disconnect. If
we drop the mutex then we could hit the issue where we race with a unbind
again.

If you guys use offload boot let me know and I'll send a new patch to test.
If not assume that in the final version this chunk will be fixed. Also
"instact" above will be fixed.




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux