Hello!
On 4/6/21 10:43 AM, John Garry wrote:
[...]
>>> Commit df2d8213d9e3 ("hisi_sas: use platform_get_irq()") failed to take
>>> into account that irq_of_parse_and_map() and platform_get_irq() have a
>>> different way of indicating an error: the former returns 0 and the latter
>>> returns a negative error code. Fix up the IRQ checks!
>>>
>>> Fixes: df2d8213d9e3 ("hisi_sas: use platform_get_irq()")
>>> Signed-off-by: Sergey Shtylyov <s.shtylyov@xxxxxxxxxxxx>
>>>
>>> ---
>>
>> Sorry, forgot to mention that this patch is against the 'fixes' branch of
>> Martin Petgersen's 'scsi.git' repo.
>
> JFYI, The HW for this v1 hw driver is all but dead, and I was considering deleting the driver.
>
> But, for now, if you want to fix up to ensure no one copies this pattern, then fine.
Yeah, that too. And the -stable kernels also need to be considered...
> Thanks,
> John
MBR, Sergey
