I don't believe this function behaves as some call sites intend. For example, if the driver implements the ->change_queue_type() method, and I say to use simple tags in sysfs, and sdev->ordered_tags is already set, I am not going to get simple tags since sdev->ordered_tags will stay set and scsi_get_tag_type() always returns MSG_ORDERED_TAG when sdev->ordered_tags is set. It's not "setting" the tag type, it's accumulating binary states until "0" is given which clears them all. Also, what is the thinking about what drivers should use as the default tag type via these interfaces? There appears to be a lot of inconsistency here. For example, unless overridden by the user, the aic7xxx driver uses orderred tags by default. On the other hand, libsas uses simple tags by default. Wouldn't we want to use simple tags by default to allow the target to reorder tagged requests as much as possible? Regardless of the thinking, I don't think this policy does not belong in the drivers at all. I'm trying to figure out what I should do in a driver I'm hacking on which is why I'm noticing all of this stuff :-) - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
