On 07/04/2021 15:58, Colin King wrote: > From: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > The for-loop iterates with a u8 loop counter i and compares this > with the loop upper limit of pm8001_ha->max_q_num which is a u32 > type. There is a potential infinite loop if pm8001_ha->max_q_num > is larger than the u8 loop counter. Fix this by making the loop > counter the same type as pm8001_ha->max_q_num. Heh, coincidentally I've read your blog post on this issue today. > Addresses-Coverity: ("Infinite loop") > Fixes: 65df7d1986a1 ("scsi: pm80xx: Fix chip initialization failure") AFAICS this still is in Martin's tree and not yet in Linus' tree. Anyways, looks good. Reviewed-by: Johannes Thumshirn <johannes.thumshirn@xxxxxxx>