On 4/4/21 2:48 PM, Andy Shevchenko wrote:
[...]
> Commit df2d8213d9e3 ("hisi_sas: use platform_get_irq()") failed to take
> into account that irq_of_parse_and_map() and platform_get_irq() have a
> different way of indicating an error: the former returns 0 and the latter
> returns a negative error code. Fix up the IRQ checks!
>
>
> Shouldn’t you unshadow error codes at the same time?
>
> return -ENOENT; ==> return IRQ;
I'm going to send that as a follow-up (cleanup) patch -- we also have devm_request_irq() with
the result overridden for no good reason...
> Fixes: df2d8213d9e3 ("hisi_sas: use platform_get_irq()")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@xxxxxxxxxxxx <mailto:s.shtylyov@xxxxxxxxxxxx>>
[...]
MBR, Sergei
