On 3/31/21 10:11 PM, Ewan D. Milne wrote:
> Some arrays return ILLEGAL_REQUEST with ASC 00h if they don't support the
> extended header, so remove the check for INVALID FIELD IN CDB.
>
> Signed-off-by: Ewan D. Milne <emilne@xxxxxxxxxx>
> ---
> drivers/scsi/device_handler/scsi_dh_alua.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c b/drivers/scsi/device_handler/scsi_dh_alua.c
> index e42390333c6e..c4c2f23cf79f 100644
> --- a/drivers/scsi/device_handler/scsi_dh_alua.c
> +++ b/drivers/scsi/device_handler/scsi_dh_alua.c
> @@ -587,10 +587,11 @@ static int alua_rtpg(struct scsi_device *sdev, struct alua_port_group *pg)
> * even though it shouldn't according to T10.
> * The retry without rtpg_ext_hdr_req set
> * handles this.
> + * Note: some arrays return a sense key of ILLEGAL_REQUEST
> + * with ASC 00h if they don't support the extended header.
> */
> if (!(pg->flags & ALUA_RTPG_EXT_HDR_UNSUPP) &&
> - sense_hdr.sense_key == ILLEGAL_REQUEST &&
> - sense_hdr.asc == 0x24 && sense_hdr.ascq == 0) {
> + sense_hdr.sense_key == ILLEGAL_REQUEST) {
> pg->flags |= ALUA_RTPG_EXT_HDR_UNSUPP;
> goto retry;
> }
>
Reviewed-by: Hannes Reinecke <hare@xxxxxxx>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@xxxxxxx +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
