On Mon, Mar 29, 2021 at 02:29:21PM -0600, Khalid Aziz wrote: > On 3/25/21 11:58 PM, Christoph Hellwig wrote: > > The ISA support in Buslogic has been broken for a long time, as all > > the I/O path expects a struct device for DMA mapping that is derived from > > the PCI device, which would simply crash for ISA adapters. > > > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > > --- > > drivers/scsi/BusLogic.c | 156 ++-------------------------------------- > > drivers/scsi/BusLogic.h | 3 - > > drivers/scsi/Kconfig | 2 +- > > 3 files changed, 6 insertions(+), 155 deletions(-) > > > > Hi Chris, > > This looks good. There is more code that can be removed, for instance > all of the code that supports "IO:" driver option to specify ISA port > addresses. enum blogic_adapter_bus_type can shrink. "limited_isa" and > "probe*" members of struct blogic_probe_options can go away. You could > add those to this patch, or if you would like, I can create a follow-on > patch to remove that code. I've added the above suggestions. If there is anything more you can easily think of let me know.
