On Thu, 25 Mar 2021 09:32:48 +0000, Gulam Mohamed wrote:
> Description
> ===========
> 1. This Kernel panic could be due to a timing issue when there is a
> race between the sync thread and the initiator was processing of
> a login response from the target. The session re-open can be invoked
> from two places:
> a. Sessions sync thread when the iscsid restart
> b. From iscsid through iscsi error handler
> 2. The session reopen sequence is as follows in user-space
> a. Disconnect the connection
> b. Then send the stop connection request to the kernel
> which releases the connection (releases the socket)
> c. Queues the reopen for 2 seconds delay
> d. Once the delay expires, create the TCP connection again by
> calling the connect() call
> e. Poll for the connection
> f. When poll is successful i.e when the TCP connection is
> established, it performs:
> i. Creation of session and connection data structures
> ii. Bind the connection to the session. This is the place
> where we assign the sock to tcp_sw_conn->sock
> iii. Sets parameters like target name, persistent address
> iv. Creates the login pdu
> v. Sends the login pdu to kernel
> vi. Returns to the main loop to process further events.
> The kernel then sends the login request over to the
> target node
> g. Once login response with success is received, it enters full
> feature phase and sets the negotiable parameters like
> max_recv_data_length,max_transmit_length, data_digest etc.
> 3. While setting the negotiable parameters by calling
> "iscsi_session_set_neg_params()", kernel panicked as sock was NULL
>
> [...]
Applied to 5.12/scsi-fixes, thanks!
[1/1] iscsi: Do Not set param when sock is NULL
https://git.kernel.org/mkp/scsi/c/9e67600ed6b8
--
Martin K. Petersen Oracle Linux Engineering
