On Wed, 2007-04-04 at 10:31 -0700, Ed Lin wrote: > Sorry. It seems the mail server has problem. The patch is here in plain > text. I hope this time it does not mess up. I have problem with > linux-scsi > mail list, if you have comment please cc me. Thanks. > --Ed Lin The lines are still broken, I'm afraid ... you can just resend as an attachement git-applypatch copes fine with that ... inline is just good for quoting and replying. > + if (hba->cardtype == st_shasta) { > + host->max_channel = 7; > + host->max_id = 16 + 1; > + } else if (hba->cardtype == st_yosemite) { > + host->max_channel = 127; > + host->max_id = 1 + 1; > + } else { > + /* st_vsc and st_vsc1 */ > + host->max_channel = 0; > + host->max_id = 128 + 1; This is OK. The use of ->channel is still a bit strange ... could we not simply use lun instead of channel (i.e. map the adapter id/lun to the mid-layer id/lun instead of using id/channel)? James - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html